“LGTM ! Only 1M line changed, approved.”
Code review: Anonymous reviewer on Pull request in an open-source project
“LGTM ! Only 1M line changed, approved.”
Code review: Anonymous reviewer on Pull request in an open-source project
“Another reason why mincing up code files into little-tiny itsy-bitsy "units" to satisfy some vague abstraction fetish learned in CS101 is a bad idea. :-)”
Code review: Anonymous reviewer on Patch to an operating system kernel
“Or maybe he's talking about ye olde readlocke, used widely for OS research throughout the middle ages. You still find that spelling in some really old CS literature.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“So leave locking to the pro's. They _also_ got it wrong, but they got it wrong several years ago, and fixed up their sh*t.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“there really is *not* a highly coveted prize for having the most different indentation in the fewest possible lines of code!”
Code review: Anonymous reviewer on Patch to an operating system kernel
“NAK NAK NAK NAK! QAK! HAK! Crap code! Stop adding undocumented interfaces. Just stop it. Now. Geeze.”
Code review: Anonymous reviewer on Patch to an operating system kernel