“And by "garbage" I really mean it. This is stuff that nobody should ever send me, never mind late in a merge window.”
Anonymous reviewer on Pull request to an operating system kernel.
Filed under savage. Added by Johan de Groot on 13 October 2026.
More code review
See all code review“So leave locking to the pro's. They _also_ got it wrong, but they got it wrong several years ago, and fixed up their sh*t.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“I hate code that has #ifdef's. It's a major design mistake, and shows that the person who coded it didn't think of it as _one_ problem, but as two.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“LGTM ! Only 1M line changed, approved.”
Code review: Anonymous reviewer on Pull request in an open-source project
“AND USING VLA'S IS ACTIVELY STUPID! It generates much more code, and much _slower_ code (and more fragile code), than just using a fixed key size would have done.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“NAK NAK NAK NAK! QAK! HAK! Crap code! Stop adding undocumented interfaces. Just stop it. Now. Geeze.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“The fact is, any time anybody makes up a new locking mechanism, THEY ALWAYS GET IT WRONG. Don't do it.”
Code review: Anonymous reviewer on Patch to an operating system kernel
Wrote this review, or think this quote shouldn’t be here? Request removal