14 quotes in Code review

Clear filters

“LGTM ! Only 1M line changed, approved.”
Code review: Anonymous reviewer on Pull request in an open-source project
“Another reason why mincing up code files into little-tiny itsy-bitsy "units" to satisfy some vague abstraction fetish learned in CS101 is a bad idea. :-)”
Code review: Anonymous reviewer on Patch to an operating system kernel
“People shut up warnings by adding code. Adding code tends to add bugs.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“Or maybe he's talking about ye olde readlocke, used widely for OS research throughout the middle ages. You still find that spelling in some really old CS literature.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“So leave locking to the pro's. They _also_ got it wrong, but they got it wrong several years ago, and fixed up their sh*t.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“The fact is, any time anybody makes up a new locking mechanism, THEY ALWAYS GET IT WRONG. Don't do it.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“there really is *not* a highly coveted prize for having the most different indentation in the fewest possible lines of code!”
Code review: Anonymous reviewer on Patch to an operating system kernel
“Code can't look this bad and still be fine.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“I hate code that has #ifdef's. It's a major design mistake, and shows that the person who coded it didn't think of it as _one_ problem, but as two.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“AND USING VLA'S IS ACTIVELY STUPID! It generates much more code, and much _slower_ code (and more fragile code), than just using a fixed key size would have done.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“The above code is sh*t, and it generates shit code. It looks bad, and there's no reason for it.”
Code review: Anonymous reviewer on Pull request to an operating system kernel
“But legal reasons do not make for good technology, or good patches that I should apply.”
Code review: Anonymous reviewer on Patch to an operating system kernel
“And by "garbage" I really mean it. This is stuff that nobody should ever send me, never mind late in a merge window.”
Code review: Anonymous reviewer on Pull request to an operating system kernel
“NAK NAK NAK NAK! QAK! HAK! Crap code! Stop adding undocumented interfaces. Just stop it. Now. Geeze.”
Code review: Anonymous reviewer on Patch to an operating system kernel